Support more than one statistic for summarizing time lists #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaineC
force-pushed
the
configurable-stats
branch
from
6c40950
to
1e2ab07
Compare
MaineC
force-pushed
the
configurable-stats
branch
from
8650250
to
4b67615
Compare
|
Not yet configurable, but a first run through the code of where changes would be needed to move to more than one statistic. At a first glance, the table doesn't look that bad. At least me, I always look at more than one statistic (I believe I started that back when I discovered the possibility to create "describe" stats with R when starting to look at series of numbers). The question here is which stats exactly to look at. As for the state of the change:
|
|
In the latest commit I replaced references to averages where in reality they already are a combination of median, average, 90th percentile. |
This commit switches code for computing averages to using numpy. This is a first step towards supporting more than one statistic for summarizing lists of times for state change of issues. Averages are easy to compute but sensitive to outliers. In particular when thinking of SLAs for times for first responses it is often more helpful to look at median, quartiles or even 90th percentile.
Currently we are only looking at averages. This adds median and 90th percentile to issues stats. Those are much less sensitive to outliers. (Think issue cleanup sessions where very old issues get closed out but then dominate the issue stats at the end of the month).
MaineC
force-pushed
the
configurable-stats
branch
from
3536281
to
aabb02f
Compare
In previous commits pure averages were replace by a dict of avg, median, 90th percentile. This makes that switch visible in docs, method names, variable names.
MaineC
force-pushed
the
configurable-stats
branch
from
aabb02f
to
6eeef9b
Compare
This was referenced Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit switches code for computing averages to using numpy.
This is a first step towards supporting more than one statistic for summarizing lists of times for state change of issues. #84
Averages are easy to compute but sensitive to outliers. In particular when thinking of SLAs for times for first responses it is often more helpful to look at median, quartiles or even 90th percentile.
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducingbug,documentation,enhancement,infrastructure, orbreaking